Skip to content

Commit

Permalink
fix: remove email from export error (#3651)
Browse files Browse the repository at this point in the history
  • Loading branch information
emilyjablonski authored Sep 21, 2023
1 parent 35c9658 commit 424a6de
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion sites/partners/__tests__/pages/listings/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe("listings", () => {
expect(exportButton).toBeInTheDocument()
fireEvent.click(exportButton)
const error = await findByText(
"Export failed. Please try again later. If the problem persists, please email [email protected]",
"There was an error. Please try again, or contact support for help.",
{
exact: false,
}
Expand Down
9 changes: 6 additions & 3 deletions sites/partners/__tests__/pages/users/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,12 @@ describe("users", () => {
const exportButton = await findByText("Export to CSV")
expect(exportButton).toBeInTheDocument()
fireEvent.click(exportButton)
const errorMessage = await findByText("Export failed. Please try again later.", {
exact: false,
})
const errorMessage = await findByText(
"There was an error. Please try again, or contact support for help.",
{
exact: false,
}
)
expect(errorMessage).toBeInTheDocument()
expect(console.log).toHaveBeenCalled()
})
Expand Down
1 change: 0 additions & 1 deletion sites/partners/page_content/locale_overrides/general.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"authentication.createAccount.firstName": "First Name",
"authentication.createAccount.lastName": "Last Name",
"errors.alert.emailConflict": "That email is already in use",
"errors.alert.exportFailed": "Export failed. Please try again later. If the problem persists, please email [email protected]",
"errors.maxLessThanMinOccupancyError": "Max Occupancy must be greater than or equal to Minimum Occupancy",
"errors.minGreaterThanMaxOccupancyError": "Minimum Occupancy must be less than or equal to Max Occupancy",
"errors.partialAddress": "Cannot enter a partial address",
Expand Down
2 changes: 1 addition & 1 deletion sites/partners/src/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export default function ListingsList() {
type="alert"
inverted
>
{t("errors.alert.exportFailed")}
{t("account.settings.alerts.genericError")}
</AlertBox>
)}
<AgTable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const ApplicationsList = () => {
timeout={5000}
dismissable
sticky={true}
alertMessage={{ message: t("errors.alert.exportFailed"), type: "alert" }}
alertMessage={{ message: t("account.settings.alerts.genericError"), type: "alert" }}
/>
)}
<NavigationHeader
Expand Down
2 changes: 1 addition & 1 deletion sites/partners/src/pages/users/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const Users = () => {
type="alert"
inverted
>
{t("errors.alert.exportFailed")}
{t("account.settings.alerts.genericError")}
</AlertBox>
)}
<AgTable
Expand Down

0 comments on commit 424a6de

Please sign in to comment.