fix: household members link on application review (#4385)

* also add reusable layout footer to the household members page
bloom-housing · Oct 10, 2024 · 29abe89 · 29abe89
1 parent e3395b8
commit 29abe89
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/sites/public/cypress/support/commands.js b/sites/public/cypress/support/commands.js
@@ -309,7 +309,7 @@ Cypress.Commands.add("step7AddHouseholdMembers", (application) => {
     cy.checkErrorMessages("not.exist")
     cy.location("pathname").should("include", "/applications/household/add-members")
   })
-  cy.getByID("app-done-household-members-button").click()
+  cy.goNext()
 })
 
 Cypress.Commands.add("step8PreferredUnits", (application) => {

diff --git a/sites/public/src/components/shared/FormSummaryDetails.tsx b/sites/public/src/components/shared/FormSummaryDetails.tsx
@@ -354,10 +354,10 @@ const FormSummaryDetails = ({
         <>
           <Card.Header className={styles["summary-header"]}>
             <Heading priority={3} size="xl" className="font-serif font-normal">
-              {t("application.review.householdDetails")}
+              {t("application.household.householdMembers")}
             </Heading>
             {editMode && !validationError && (
-              <Link href="/applications/household/preferred-units">{t("t.edit")}</Link>
+              <Link href="/applications/household/add-members">{t("t.edit")}</Link>
             )}
           </Card.Header>
 

diff --git a/sites/public/src/pages/applications/household/add-members.tsx b/sites/public/src/pages/applications/household/add-members.tsx
@@ -91,6 +91,7 @@ const ApplicationAddMembers = () => {
           backLink={{
             url: conductor.determinePreviousUrl(),
           }}
+          conductor={conductor}
         >
           <HouseholdSizeField
             assistanceUrl={t("application.household.assistanceUrl")}
@@ -122,17 +123,6 @@ const ApplicationAddMembers = () => {
               {t("application.household.addMembers.addHouseholdMember")}
             </Button>
           </CardSection>
-          <CardSection className={styles["application-form-action-footer"]}>
-            <Button
-              onClick={() => {
-                conductor.returnToReview = false
-                void handleSubmit(onSubmit)()
-              }}
-              id={"app-done-household-members-button"}
-            >
-              {t("t.next")}
-            </Button>
-          </CardSection>
         </ApplicationFormLayout>
       </Form>
     </FormsLayout>