ci: generate schemas and documentation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's good practice, one source of truth etc. Signed-off-by: Petr Štetiar <[email protected]>
Otherwise we might get following issue with older versions: AttributeError: module 'yaml' has no attribute 'FullLoader' Signed-off-by: Petr Štetiar <[email protected]>
Seems to be not used anywhere. Signed-off-by: Petr Štetiar <[email protected]>
* generate JSON schemas and documentation * upload documentation artifacts * create index.html for GitHub pages * publish documentation as GitHub pages (only on main branch) Signed-off-by: Petr Štetiar <[email protected]>
aparcar
reviewed
Apr 10, 2021
| @@ -39,5 +39,37 @@ jobs: | |||
| make -j$(($(nproc)+1)) -C $(pwd)/build all | |||
| sudo make -C $(pwd)/build install | |||
|
|
|||
| - name: Install Python dependencies for YAML schemas | |||
| run: | | |||
| sudo apt-get install python3-setuptools | |||
There was a problem hiding this comment.
I think setuptools is already installed:
https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-README.md
There was a problem hiding this comment.
It's not that hard to check that the documentation is wrong. Who reads the documentation? :-) FYI real error I've tried to fix by that line.
There was a problem hiding this comment.
Reported upstream, strange that they messed this up.
There was a problem hiding this comment.
Well, it seems like they document and install python-setuptools for Python2, whereas I'm installing setuptools for Python3.
blogic
force-pushed
the
main
branch
10 times, most recently
from
43ed9dc
to
e9431c8
Compare
blogic
force-pushed
the
main
branch
3 times, most recently
from
74de820
to
1025971
Compare
blogic
force-pushed
the
main
branch
7 times, most recently
from
8c5079d
to
0a9ff8a
Compare
blogic
force-pushed
the
main
branch
4 times, most recently
from
110fc02
to
66694c2
Compare
blogic
force-pushed
the
main
branch
9 times, most recently
from
4fdaeed
to
1bdc8de
Compare
blogic
force-pushed
the
main
branch
5 times, most recently
from
704e471
to
08e0c28
Compare
blogic
force-pushed
the
main
branch
2 times, most recently
from
f926153
to
0a49566
Compare
blogic
force-pushed
the
main
branch
3 times, most recently
from
80727d5
to
7bc2f00
Compare
blogic
force-pushed
the
main
branch
2 times, most recently
from
68b8888
to
35adc26
Compare
blogic
force-pushed
the
main
branch
6 times, most recently
from
3ff0a8d
to
6d83248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GitHub pages
Preview https://ynezz.github.io/openwrt-ucentral-schema/
GitHub pages needs to be enabled:
Then the actual docs would get published once the CI workflow on main branch finishes.