Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @coinbase/wallet-sdk to v3.7.2 #1925

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

sirtimid
Copy link
Contributor

@sirtimid sirtimid commented Sep 28, 2023

Description

This Pull Request aims to address the installation issue encountered when installing @web3-onboard/coinbase on Node v18.18.0. The root of this issue has been identified as a dependency on @coinbase/[email protected], which fails to install correctly, thereby causing the installation of the parent package to fail.

To resolve this, the PR updates the @coinbase/wallet-sdk dependency to version 3.7.2. This version increment is anticipated to contain the necessary fixes to ensure a smooth installation process on the specified Node version, thus enhancing the stability and reliability of the @web3-onboard/coinbase package.

Related issue: #1924

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@solana/web3.js 1.78.0...1.74.0 None +6/-4 12.9 MB _chido

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Adamj1232 Adamj1232 merged commit e8fd319 into blocknative:develop Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants