Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link & update nomenclature #1881

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add link & update nomenclature #1881

merged 1 commit into from
Aug 18, 2023

Conversation

laurencedelisle
Copy link
Contributor

Description

added link that was missing for quickstart & updated to Web3 Onboard.

Screen Shot 2023-08-15 at 9 25 24 PM Screen Shot 2023-08-15 at 9 25 14 PM

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • [ x] Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

added link that was missing for quickstart & updated to Web3 Onboard.
@leightkt leightkt merged commit 19ee5ec into develop Aug 18, 2023
2 checks passed
@leightkt leightkt deleted the add-link branch August 18, 2023 15:48
Adamj1232 added a commit that referenced this pull request Aug 29, 2023
* Add link & update nomenclature (#1881)

added link that was missing for quickstart & updated to Web3 Onboard.

* Update Trezor to 9.0.11 (#1882)

* Update Trezor to 9.0.11

Getting error:

TypeError: Cannot destructure property 'BridgeV2' of 'transport_1.default' as it is undefined.

This seems to have changed recently (within the last couple of days) as this is breaking in one of our automated tests.

Info:

@trezor/connect v9.0.7

How to reproduce
This happens consistently when trying to import the module.


Update to 9.0.11 should solve this

* Update package.json version to 2.4.3-alpha.1

---------

Co-authored-by: Kat Leight <[email protected]>

* feat: updated xdefi icon (#1870)

* feat: updated xdefi icon

* chore: package version bumps

* Update packages/xdefi/package.json

* chore: updated package.json

---------

Co-authored-by: Kat Leight <[email protected]>

* Feat/add additional required methods props to wc (#1883)

* add ability to pass additionalRequiredMethods in WalletConnectOptions

* bump minor version to alpha.1

* add documentation for additionalRequiredMethods

* bump @walletconnect/ethereum-provider to ^2.10.0

* Add to internal demo and docs, update readme

---------

Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Adam Carpenter <[email protected]>

* Bump versions and yarn, add WC instance return for session info

---------

Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Laurence <[email protected]>
Co-authored-by: Rohan <[email protected]>
Co-authored-by: Kat Leight <[email protected]>
Co-authored-by: Jackson Hong <[email protected]>
Co-authored-by: marc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants