Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for balance changes #152

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Fixes for balance changes #152

merged 3 commits into from
Dec 4, 2023

Conversation

tyler-smith
Copy link

Change the order of operations when decoding call frames to address various balance change issues including:

  • Missing native transfers to accounts that we fail to decode contracts for correctly.
  • Unnecessary "0 transfers" that result from some calls.
  • False gas transfer information on traces for reverting transactions.

@tyler-smith
fix: Correctly handle "0 transfers."
e100c85 
We get some Transfer events where 0 is actually transferred. We
show these in decodings and logs, but we will now not show them
in the balance changes list since no balance changed.
@tyler-smith
fix: Don't add false gas transfers for failed txs.
aa3465c
@tyler-smith
fix: Account for native transfers even if contract fails to decode.
2e2e16c
@tyler-smith tyler-smith merged commit dac1fe9 into main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tyler-smith