Feat/715 revocation list passes assertion id parameter #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raiseandfall
changed the title
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 92.70% 92.78% +0.08%
==========================================
Files 70 71 +1
Lines 1055 1067 +12
Branches 188 189 +1
==========================================
+ Hits 978 990 +12
Misses 73 73
Partials 4 4
Continue to review full report at Codecov.
|
lemoustachiste
approved these changes
Sep 5, 2020
| @@ -10,8 +11,7 @@ function appendApiIdentifier (url: string, explorerAPI: ExplorerAPI): string { | |||
| throw new Error(`No keyPropertyName defined for explorerAPI ${explorerAPI.serviceName}`); | |||
| } | |||
|
|
|||
| const separator = url.includes('?') ? '&' : '?'; | |||
| return `${url}${separator}${explorerAPI.keyPropertyName}=${explorerAPI.key}`; | |||
| return safelyAppendUrlParameter(url, explorerAPI.keyPropertyName, explorerAPI.key); | |||
raiseandfall
deleted the
feat/715-revocationLis-pass-assertion-id-parameter
branch
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#715