Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when ethereum_rpc_url is None #211

Closed
wants to merge 1 commit into from
Closed

Error when ethereum_rpc_url is None #211

wants to merge 1 commit into from

Conversation

antonellopasella
Copy link
Contributor

PR for #210

@lemoustachiste
Copy link
Member

ok so if I understand correctly this will silently fail now?

@lemoustachiste
Copy link
Member

I don't this is a good change, it's obfuscating potential misconfiguration and I would rather see an error to debug and understand that I need to configure something than to silently skip a step that I may need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonellopasella @lemoustachiste