feat: Create z3_pass #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bliutech
requested changes
Jul 18, 2024
solver/passes/z3_pass
Outdated
| def visitVarExpr(self, vex: VarExpr) -> z3.ExprRef: | ||
| first: z3.ExprRef = vex.first.acceptRet(self) | ||
| if vex.second: | ||
| second: z3.ExprRef = vex.second.acceptRet(self) |
There was a problem hiding this comment.
This is very close. I think the idea is actually to call AcceptRet on vex.second.first. We want to skip over the AndExpr and OrExpr since these won't return enough context to initialize the Z3 Object.
I left one comment unresolved because I'm not sure if I fixed it correctly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Test Plan