-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linting options #214
add linting options #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for such thorough work.
About using unwraps - totally agree. But I think we will come to this after the Layout feature is delivered and we start to stabilize APIs approaching to stable release. I will consider anyhow
for sure.
What do you think about enhancing linter in the .github/workflows linter
step?
now also enhanced the workflow |
still working on another suggestion - maybe I can finish that later on! |
@blitzarx1 I started adding anyhow - maybe you could have a look at it? |
lets extract Also I am not sure this is the right time to add anyhow usage, while I am mid adding Layout feature. Let us return to anyhow after the Layout when we will be on stabilization track. @bircni I am ready to continue wiht this PR, but without anyhow changes. |
was just a check gonna revert them and finish the pr to make it ready for review finally! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good begining for the stabilization track
I enabled some lints in clippy to improve the style of the code.
There are some todos open with missing panic docs.
It is not that good to use unwraps as we don't want to crash the users experience, maybe instead use the crate
anyhow
to safely handle errors.