Specifically specify required features for dependent crates #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blitzarx1
approved these changes
Nov 13, 2023
|
And thank you for this awesome graph visualization library :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR intends to clean up some external crate features that aren't required for
egui_graphsto work. Specifically, this removesegui/default_fontsandpetgraph/graphmap. I've checked the other dependencies as well but it appears they don't further enable features that aren't required.Not including
egui/default_fonts(which enablesepaint/default_fonts) might be particularly interesting because it pulls in font files that have additional licenses. This is what initially triggered me to make this change 🙂.