Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for pulling docker image without service #83

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

agaffney
Copy link
Contributor

@agaffney agaffney commented Mar 5, 2024

Fixes #49

Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but not blocking this being merged.

}
return nil
}

func (p *PackageInstallStepDocker) uninstall(cfg Config, pkgName string) error {
// Nothing to uninstall if we were only fetching the image
if p.PullOnly {
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also do that

@agaffney agaffney merged commit 4d687ae into main Mar 6, 2024
6 checks passed
@agaffney agaffney deleted the feat/docker-pull-only branch March 6, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some packages don't need to be started
2 participants