feat: add Ogmios package #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
reviewed
Mar 5, 2024
wolf31o2
requested changes
Mar 6, 2024
pkgmgr/registry.go
Outdated
| @@ -91,6 +91,37 @@ docker run --rm -ti ghcr.io/blinklabs-io/mithril-client:0.7.0-1 $@ | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "ogmios", | |||
| Version: "v5.6.0-mainnet", | |||
There was a problem hiding this comment.
We'll need 6.0+ for compatibility with our given cardano-node versions.
I suggest v6.1.0, instead.
pkgmgr/registry.go
Outdated
| Docker: &PackageInstallStepDocker{ | ||
| ContainerName: "ogmios", | ||
| Image: "cardanosolutions/ogmios:v5.6.0-mainnet", | ||
| Env: map[string]string{ |
There was a problem hiding this comment.
Ogmios doesn't read env, but if we wanted to use some and then pipe them through to the command arguments, that could work.
verbotenj
force-pushed
the
feat/ogmios-pkg
branch
from
baa8a9d
to
3c109c8
Compare
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/ogmios-pkg
branch
from
3c109c8
to
f6f1e39
Compare
wolf31o2
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing package ogmios (= v6.1.0)
v6.1.0: Pulling from cardanosolutions/ogmios