Emitter: updated drop tracking #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspluna
changed the title
mootz12
requested changes
Nov 16, 2023
emitter/src/storage.rs
Outdated
| .get(&EmitterDataKey::DropStatus) | ||
| .unwrap_optimized() | ||
| .get::<EmitterDataKey, bool>(&EmitterDataKey::Dropped(backstop.clone())) | ||
| .is_some() |
There was a problem hiding this comment.
This feels like it could introduce a bug if changes are made down the line, as someone could store "false" here with the assumption the address can be dropped too.
Can we change is_some() to unwrap_optimized()?
mootz12
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how we track what drops have occurred to use a list of addresses instead of a bool status.
Resolves: #145