Functions with no arguments #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
func-no-args
branch
from
3f6220e
to
f2cd980
Compare
| def test_function(): | ||
| base = dshape('(int32, int64) -> int64') | ||
| assert_dshape_equal(base, base) | ||
| cases = ( |
There was a problem hiding this comment.
any reason not to make this a pytest.mark.parametrize function?
There was a problem hiding this comment.
I didn't want to re-test the base case case over an over. I can split it out into two functions
llllllllll
force-pushed
the
func-no-args
branch
from
f2cd980
to
8399c70
Compare
|
merging on pass |
llllllllll
added a commit
that referenced
this pull request
Jan 12, 2016
Functions with no arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements: #162