Add documentation and tests for DQL - unique() #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing tests and documentation related to the DQL function `unique()`
sammbeller
reviewed
Jan 16, 2025
Comment on lines
+17
to
+18
| test("multiple unique", () => expectEvals("unique([1, 1, 1])", [1])); | ||
| test("multiple same", () => expectEvals("unique([1, 3, 7, 3, 1])", [1, 3, 7])); |
There was a problem hiding this comment.
Are the names for these tests flipped?
There was a problem hiding this comment.
Nah... It could be based on your perspective... The first test for a test case of multiple occurence of a unique value, and the second tests for multiple occurences of different but still a limited set of values.
Naming is hard... :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing tests and documentation related to the DQL function
unique()