ARM:Add Jtag to Dormant sequence in case the target has both jtag and swd #1959
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and is jtag by default
mean00
force-pushed
the
mean00/add_jtag_to_dormant_sequence
branch
from
ee984ad
to
b79fc11
Compare
dragonmux
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Having picked through the spec to check this, this all looks good. With our only review notes (stylistic) fixed, please rebase this on main and we'll get it merged.
We checked the specification where it talks about how to step through the various state machines, and per the spec, those 8 high cycles are required:
| /* Send at least 8 SWCLKTCK cycles with SWDIOTMS HIGH */ | ||
| swd_line_reset_sequence(false); | ||
|
|
||
| /* If the target is both Jtag and SWD with Jtag as default, switch Jtag->DS first. |
There was a problem hiding this comment.
Please put the opening /* on its own line like in the comment blocks above this.
| /* If the target is both Jtag and SWD with Jtag as default, switch Jtag->DS first. | ||
| * See B5.3.2 | ||
| */ | ||
| DEBUG_INFO("Switching from jtag do dormant \n"); |
There was a problem hiding this comment.
Please remove the extra space between the end of the sentence and the \n, and capitalise JTAG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
For what i could see, it still works with RP2040 and older Arm chips i have (STM32F1/GD32F3)
Tested on a chip with both Jtag & SWD/Default jtag + Debug Protocol v3, it works with the change, doesnt without
NB: Not completely sure the 8 trailer '1' bits are really needed, it works fine with, was there in the demo code
Your checklist for this pull request
Closing issues