Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosted: Correct copyright notices #1561

Merged
merged 1 commit into from
Jul 23, 2023
Merged

hosted: Correct copyright notices #1561

merged 1 commit into from
Jul 23, 2023

Conversation

sidprice
Copy link
Contributor

The copyright notices on a couple of BMDA related files were not up-to-date

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

@dragonmux dragonmux added this to the v1.10 milestone Jul 23, 2023
@dragonmux dragonmux added BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Documentation Project documentation labels Jul 23, 2023
dragonmux
dragonmux reviewed Jul 23, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this correction PR - there's one item in ftdi.h that possibly needs tweaking but with that addressed, we're happy to merge this

src/platforms/hosted/windows/ftdi.h Outdated Show resolved Hide resolved
dragonmux
dragonmux reviewed Jul 23, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@dragonmux dragonmux merged commit cbcf29d into blackmagic-debug:main Jul 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Documentation Project documentation
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@sidprice @dragonmux