Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
While toying with LTO and doing a BMDA build, GCC warned of a type error in the CRC32 header. On checking it out, the type for the length parameter was indeed mismatched between header and both implementations.
This PR addresses this and does cleanup on the CRC32 implementations to bring them up to standard and make them easier to read and understand. Tested against a LPC4370 on both BMP and using BMDA, this offers no functional change but does fix some undefined behaviour.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues