Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: Additions for case checking in source code #1555

Merged
merged 1 commit into from
Jul 21, 2023
Merged

clang-tidy: Additions for case checking in source code #1555

merged 1 commit into from
Jul 21, 2023

Conversation

sidprice
Copy link
Contributor

This PR adds case checking for various elements of the source code.

These checks were added to assist contributors in checking their submissions against the project contribution requirements.

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

@dragonmux dragonmux added this to the v1.10 milestone Jul 21, 2023
@dragonmux dragonmux added Enhancement General project improvement CI Continuous Integration System labels Jul 21, 2023
dragonmux
dragonmux reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one item's stood out in review - with that addressed, we're happy to merge this. Thank you for the contribution!

.clang-tidy Show resolved Hide resolved
dragonmux
dragonmux approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@dragonmux dragonmux merged commit 53b46e6 into blackmagic-debug:main Jul 21, 2023
6 checks passed
@sidprice sidprice deleted the clang-tidy-additions branch July 22, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration System Enhancement General project improvement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@sidprice @dragonmux