Fix: remote protocol SWD hangs #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_process_jtag()
…r REMOTE_IN_PAR in remote_packet_process_swd()
…r REMOTE_IN in remote_packet_process_swd()
…r REMOTE_OUT in remote_packet_process_swd()
…r REMOTE_OUT_PAR in remote_packet_process_swd()
dragonmux
added
Bug
dragonmux
force-pushed
the
fix/remote-protocol-swd-hangs
branch
from
62f5bb6
to
38bee56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR addresses a regression introduced in PR #1531 which forgot that the SWD bitbanging code needs to deal with target_clk_divider = UINT32_MAX fully. The effect of this mistake was that SWD would "hang" and soft-crash the probe.
We've also taken the opportunity to clean up the SWD remote protocol implementation the same as we did the JTAG implementation, saving a couple of bytes of Flash from that routine.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues