Feature: HC32L110 support #1241
Conversation
vesim987
force-pushed
the
hc32l110
branch
7 times, most recently
from
c3ee7a7
to
422c24c
Compare
src/target/target_flash.c
Outdated
| { | ||
| if (t->flash_mode) | ||
| if (t->flash_mode) { | ||
| t->current_flash_operation = op; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Please can you rebase this against main, or let us know if you're happy for us to do so for you, so we can review and merge this? |
|
Given the time between asking for this to be rebased and now, we're going to get on and do so, addressing Perigoso's review points. Getting this sorted out and merged for v1.10 would be really good. |
dragonmux
force-pushed
the
hc32l110
branch
7 times, most recently
from
5fe5454
to
805513a
Compare
There was a problem hiding this comment.
One of the issues I noted in a previous review was not yet addressed (to be fair I didn't really dive into the problem and provide context), that is, the new flash operation status is implemented on the wrong scope, it's kept on the target scope when it should belong to the flash structs.
Instead of thoroughly explaining what needed to change in review I found it easier to just re-write the affected code, you can find the changes in perigoso/fix/hc32l110, 8c353a4 and 08c5786 replace a9ae7c4 and there's an additional fix-up because of function signature changes 8d213d9
…ry maps of the HC32L110 parts
…r is not in the Flash
…nting the definitions
Detailed description
In this PR I've implemented support for detecting and flashing HC32L110B(A variant should work too, but i don't have it to test). And also introduce flash_operation in
flash.prepareandflash.doneYour checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues