gdb_packet: add build flag to disable no ack mode

src/Makefile

@@ -122,6 +122,10 @@ ifdef RTT_IDENT
 CFLAGS += -DRTT_IDENT=$(RTT_IDENT)
 endif
 
+ifeq ($(ENABLE_NOACKMODE), 1)
+CFLAGS += -DENABLE_NOACKMODE=1
+endif
+
 OBJ = $(patsubst %.S,%.o,$(patsubst %.c,%.o,$(SRC)))
 
 $(TARGET): include/version.h $(OBJ)

src/gdb_main.c

@@ -41,6 +41,12 @@
 #include "rtt.h"
 #endif
 
+#if ENABLE_NOACKMODE == 1
+#define SUPPORTED_NOACKMODE ";QStartNoAckMode+"
+#else
+#define SUPPORTED_NOACKMODE ""
+#endif
+
 #if defined(_WIN32)
 #include <malloc.h>
 #else
@@ -430,7 +436,8 @@ static void exec_q_supported(const char *packet, const size_t length)
  */
  gdb_set_noackmode(false);
 
- gdb_putpacket_f("PacketSize=%X;qXfer:memory-map:read+;qXfer:features:read+;QStartNoAckMode+", GDB_MAX_PACKET_SIZE);
+ gdb_putpacket_f(
+ "PacketSize=%X;qXfer:memory-map:read+;qXfer:features:read+" SUPPORTED_NOACKMODE, GDB_MAX_PACKET_SIZE);
 }
 
 static void exec_q_memory_map(const char *packet, const size_t length)

src/gdb_packet.c

@@ -39,10 +39,15 @@ typedef enum packet_state {
  PACKET_GDB_CHECKSUM_LOWER,
 } packet_state_e;
 
+#if ENABLE_NOACKMODE == 1
 static bool noackmode = false;
+#else
+static const bool noackmode = false;
+#endif
 
 void gdb_set_noackmode(bool enable)
 {
+#if ENABLE_NOACKMODE == 1
  /* 
  * If we were asked to disable no ack mode, and it was previously enabled,
  * it might mean we got a packet we determined to be the first of a new
@@ -57,6 +62,10 @@ void gdb_set_noackmode(bool enable)
 
  DEBUG_GDB("%s no ack mode\n", enable ? "Enable" : "Disable");
  noackmode = enable;
+#else
+ if (enable)
+ DEBUG_ERROR("Tried to set no ack mode but it's not enabled in this build\n");
+#endif
 }
 
 packet_state_e consume_remote_packet(char *const packet, const size_t size)