gdb_packet: Log vasprintf failures in gdb_voutf()

blackmagic-debug · May 27, 2024 · 8b4d376 · 8b4d376
1 parent 7ba6897
commit 8b4d376
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/gdb_packet.c b/src/gdb_packet.c
@@ -349,9 +349,12 @@ void gdb_out(const char *const buf)
 
 void gdb_voutf(const char *const fmt, va_list ap)
 {
- char *buf;
- if (vasprintf(&buf, fmt, ap) < 0)
+ char *buf = NULL;
+ if (vasprintf(&buf, fmt, ap) < 0) {
+ /* Heap exhaustion. Report with puts() elsewhere. */
+ DEBUG_ERROR("gdb_voutf: vasprintf failed\n");
  return;
+ }
 
  gdb_out(buf);
  free(buf);