Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method named collect_all_version_components to work around HUB_25945 #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2021

Add a parameters object to the get_version_components method so it will take an "offset" value. New method named collect_all_version_components to work around HUB_25945 where totalCount which is returned by the api is correct but the actual list of items returned is less that totalCount.

…ll take an "offset" value.

New method named collect_all_version_components to work around HUB_25945 where totalCount which is returned by the api is correct but the actual list of items returned is less that totalCount.
Copy link
Contributor

@gsnyder2007 gsnyder2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are working on an improved way to page results that will apply more broadly to all the methods that presently retrieve things like projects, versions, components so collect_all_version_components will become redundant when that happens. Could you please take collect_all_version_components out, and place that in your calling code (that uses get_version_components)? I'll accept the improvement to get_version_components which will allow your code to work as shown (but in your calling program).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants