New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proxy for github request and allow scheme in proxy host #2

Open

taikuukaits wants to merge 2 commits into master from proxy-fix

Contributor

taikuukaits commented Apr 6, 2018

Fixes two issues:

Use a proxy if available to download the detect script from github. This code was moved from the detect powershell script up to the tfs script. Unfortunately we will now need to keep them in sync.
When a scheme is provided in the host, the UriBuilder was failing to parse it. Now we treat host as a uri and let the builder's constructor parse it. This change also happened on the detect repository.

taikuukaits added 2 commits

April 6, 2018 13:01


          Updated cached detect script.

d08f56f


          Added proxy and web request helper methods from detect script to tfs …

207d7b7

…script. Getting the github script now uses proxy if available.

taikuukaits mentioned this pull request

Updates to the Proxy Handling #1

Open

kms254 commented Apr 11, 2018

@taikuukaits Any update getting this PR through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet