Fix footer command & Partially revert commit a9e5008 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footer command had syntax issues that prevented the use of it. I mentioned about it on bkerler#564 but decided to fix it myself for everyone. Signed-off-by: Christopher Lentocha <[email protected]>
This commit fixes this from happening on running a edl command without rebooting the device on every command:
```
Qualcomm Sahara / Firehose Client V3.62 (c) B.Kerler 2018-2024.
main - Using loader 0000000000000000_b01193679ab2eac7_fhprg_peek.bin ...
main - Waiting for the device
main - Device detected :)
main - Mode detected: firehose
Traceback (most recent call last):
File "/usr/local/bin/edl", line 393, in <module>
base.run()
File "/usr/local/bin/edl", line 295, in run
version = conninfo.get("data").version
AttributeError: 'NoneType' object has no attribute 'version'
root@HP-PAVILION-590:~#
```
Signed-off-by: Christopher Lentocha <[email protected]>
On "Fix footer command" commit Signed-off-by: Christopher Lentocha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this on my last PR but I read in the README.md this is indeed for eMMC devices.