Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add application version in settings #17

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: ✨ add application version in settings #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,7 @@
<string name="github" translatable="false">GitHub</string>
<string name="github_summary">Check out our GitHub repository and help us improve the app</string>
<string name="github_repository_url" translatable="false">https://github.com/bk20dev/forest</string>
<string name="version">Version: v1.0.0</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's possible to get the version name from the build.gradle file. This way, there would be no chance of forgetting to update version codes.
https://stackoverflow.com/questions/4471025/how-can-you-get-the-manifest-version-number-from-the-apps-layout-xml-variable
This approach will probably require writing some kind of dynamic Preference generation/altering rendered preferences.
Also could you make the first line say {AppName} v{VersionName}, like Forest v1.0.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to set this up, but sadly I am not able to understand what I should be doing. I am new to android development, sorry for the inconvenience

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, Forest uses Gradle to automate its build process (it's the default option). Under Gradle Scripts tab in Android Studio you will find a build.gradle (Module :app) file. It contains information about the app dependencies as well as some "meta data", including the current application version.
The StackOverflow answer I linked shows how to take that information and make it accessible as a string resource, which you can then show to the user somewhere. For current version of Forest, this string resource should resolve to "1.0" as set in build.gradle.
I would love to see the app version as a tile with two lines. The second line you provided looks okay, but make the first line ("header") display "Forest v1.0". Make it flexible, so the app name (Forest) and version name (1.0) are not hardcoded, but rather taken from strings.xml and build.gradle (as a string resource). I'm not sure if it is possible to interpolate two strings in strings.xml, but it's surely possible to do from code. You will need to find a place (SettingsFragment.kt) to write some string-interpolation logic and set it in the preference fragment. Check out the code i wrote there, because it shows how to access a preference.

<string name="version_summary">The current version of the app</string>
<string name="github_releases_url" translatable="false">https://github.com/bk20dev/forest/releases</string>
</resources>
10 changes: 10 additions & 0 deletions app/src/main/res/xml/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@

</Preference>

<Preference
android:summary="@string/version_summary"
android:title="@string/version">

<intent
android:action="android.intent.action.VIEW"
android:data="@string/github_releases_url" />

</Preference>

</PreferenceCategory>

</PreferenceScreen>