Make gms module usable again with Gitlab #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bjvrielink
commented
Apr 10, 2019
•
bjvrielink
commented
- Updated Travis (dropped ancient Ruby version, added newer Ruby and Puppet versions)
- Added patch for submodules in Gitlab (ricou84)
- Added patch to make Gitlab Api version configurable (mstinsky)
- Added gitlab-ci config
- Updated metadata.json dependencies
- Updated default Puppet version in Gemfile
replace / by %2F in project stored on sub-sub-group
- Set default Puppet version to 5.5.0 - Updated dependencies in metadata.json to more modern versions Note: not switching to Puppet6 yet. It probably will work, but I'm not testing too much with Puppet6 myself.
In Travis, don't test old Puppet with new Ruby versions.
- Deleted some non-supported combinations of Puppet and Ruby from Travis Matrix - Added some form of matrix for Gitlab CI - Gitlab CI fixes for old Puppet versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.