Add OOM testing of parsing replicas

Signed-off-by: Björn Svensson <[email protected]>
bjosv · Oct 11, 2024 · 8acf6aa · 8acf6aa
1 parent 12920a0
commit 8acf6aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/cluster.c b/src/cluster.c
@@ -958,7 +958,6 @@ static dict *parse_cluster_nodes(valkeyClusterContext *cc, valkeyReply *reply) {
                     ret = cluster_master_slave_mapping_with_name(
                         cc, &nodes_name, master, master->name);
                     if (ret != VALKEY_OK) {
-                        freeValkeyClusterNode(master);
                         goto error;
                     }
                 }

diff --git a/tests/ct_out_of_memory_handling.c b/tests/ct_out_of_memory_handling.c
@@ -125,6 +125,7 @@ void test_alloc_failure_handling(void) {
         cc = valkeyClusterContextInit();
         assert(cc);
     }
+    cc->flags |= VALKEYCLUSTER_FLAG_ADD_SLAVE;
 
     // Add nodes
     {
@@ -170,14 +171,14 @@ void test_alloc_failure_handling(void) {
 
     // Connect
     {
-        for (int i = 0; i < 128; ++i) {
+        for (int i = 0; i < 148; ++i) {
             prepare_allocation_test(cc, i);
             result = valkeyClusterConnect2(cc);
             assert(result == VALKEY_ERR);
             ASSERT_STR_EQ(cc->errstr, "Out of memory");
         }
 
-        prepare_allocation_test(cc, 128);
+        prepare_allocation_test(cc, 148);
         result = valkeyClusterConnect2(cc);
         assert(result == VALKEY_OK);
     }