Log failing benchmark test

bjosv · Sep 23, 2024 · 0a6157d · 0a6157d
1 parent 6bb24e5
commit 0a6157d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -122,7 +122,13 @@ jobs:
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
       - name: Install dependencies
-        run: brew install ninja valkey
+        run: brew install ninja
+        # run: brew install ninja valkey
+      - name: Install Valkey for non-cluster tests
+        run: |
+          # git clone --depth 1 --branch 7.2.5 https://github.com/valkey-io/valkey.git
+          git clone --depth 1 --branch 8.0.0 https://github.com/valkey-io/valkey.git
+          cd valkey && BUILD_TLS=yes make install
       - name: Build using CMake
         run: |
           mkdir build && cd build

diff --git a/.github/workflows/db-compatibility.yml b/.github/workflows/db-compatibility.yml
@@ -13,6 +13,7 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - valkey-version: '8.0.0'
           - valkey-version: '7.2.5'
     steps:
       - name: Prepare

diff --git a/tests/client_test.c b/tests/client_test.c
@@ -1561,11 +1561,17 @@ static void test_throughput(struct config config) {
     printf("\t(%dx PING (pipelined): %.3fs)\n", num, (t2 - t1) / 1000000.0);
 
     replies = vk_malloc_safe(sizeof(valkeyReply *) * num);
-    for (i = 0; i < num; i++)
-        valkeyAppendCommand(c, "LRANGE mylist 0 499");
+    for (i = 0; i < num; i++) {
+        int res = valkeyAppendCommand(c, "LRANGE mylist 0 499");
+        if (res != VALKEY_OK)
+            printf("\tvalkeyAppendCommand failure, i=%d res=%d\n", i, res);
+    }
     t1 = usec();
     for (i = 0; i < num; i++) {
-        assert(valkeyGetReply(c, (void *)&replies[i]) == VALKEY_OK);
+        int res = valkeyGetReply(c, (void *)&replies[i]);
+        if (res != VALKEY_OK)
+            printf("\tvalkeyGetReply failure, i=%d res=%d\n", i, res);
+        assert(res == VALKEY_OK);
         assert(replies[i] != NULL && replies[i]->type == VALKEY_REPLY_ARRAY);
         assert(replies[i] != NULL && replies[i]->elements == 500);
     }