Minimal fix for issue #22 #57
Open
+50
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Bonzini <[email protected]>
In order to avoid a memory leak, drop references to the unsubscribe action as soon as it is not needed anymore. This is also a bugfix, because self.unsubscribed was set to true only after the unsubscribe action returned. Therefore the unsubscribe action could be invoked more than once. Signed-off-by: Paolo Bonzini <[email protected]>
|
Hello, I don't want to send spam but since this is directly related I'll just leave a link to my comment in another issue: #22 (comment) |
guillaumearm
added a commit
to guillaumearm/oc
that referenced
this pull request
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal fix for the subscription leak in #22. I simply went through all operators and ensured that before every onCompleted the subscription is dropped.
I also found a memory leak in the Subscription class. I am fixing it in this pull request since it is mostly visible with operators that complete before their underlying stream.