Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging < main #2966

Merged
merged 86 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
ed2427f
LINT: Fix rubocop issue `Layout/IndentationConsistency`
Lubosky May 9, 2024
11a2887
Regenerate RuboCop todo list
Lubosky May 9, 2024
4a3a652
Configure EditorConfig settings
Lubosky May 10, 2024
8ff47aa
LINT: Fix RuboCop issues
Lubosky May 13, 2024
eab83e9
LINT: Fix RuboCop issues
Lubosky May 13, 2024
6d6d2be
LINT: Fix RuboCop performance issues
Lubosky May 13, 2024
2bd40e6
LINT: Fix RuboCop layout issues
Lubosky May 13, 2024
a02d49c
LINT: Fix rubocop issue `Lint/AmbiguousOperator`
Lubosky May 13, 2024
8a8ec8a
LINT: Fix rubocop issue `Layout/BlockAlignment`
Lubosky May 13, 2024
5283a3e
LINT: Fix rubocop issue `Layout/BlockAlignment`
Lubosky May 13, 2024
fedb15c
LINT: Disable rubocop issue `Lint/LiteralAsCondition`
Lubosky May 13, 2024
91b56e4
LINT: Disable rubocop issue `Lint/NonLocalExitFromIterator`
Lubosky May 13, 2024
60e7fee
LINT: Fix RuboCop issues
Lubosky May 13, 2024
8d2ca27
LINT: Disable rubocop issue `Style/MissingRespondToMissing`
Lubosky May 13, 2024
798a184
LINT: Fix RuboCop issues
Lubosky May 13, 2024
01d7c6a
LINT: Fix RuboCop indentation issues
Lubosky May 13, 2024
54cdc52
LINT: Fix RuboCop issues
Lubosky May 13, 2024
9e34753
LINT: Fix RuboCop issues unsafe to auto-correct
Lubosky May 13, 2024
e7f0156
LINT: Specify environments for `Rails/UnknownEnv` rule
Lubosky May 13, 2024
4e73009
LINT: Fix rubocop issue `Performance/Detect`
Lubosky May 13, 2024
dd15190
LINT: Fix RuboCop issues
Lubosky May 13, 2024
2b523c0
LINT: Fix rubocop issue `Style/RedundantStringEscape`
Lubosky May 13, 2024
4bf47e0
LINT: Fix rubocop issue `Style/RedundantSelf`
Lubosky May 13, 2024
e52c9b8
LINT: Disable rubocop issue `Style/ArgumentsForwarding`
Lubosky May 13, 2024
b300428
LINT: Fix rubocop issue `Style/ConditionalAssignment`
Lubosky May 13, 2024
0af652f
Regenerate RuboCop todo list
Lubosky May 13, 2024
3cce4cd
LINT: Fix RuboCop issues
Lubosky May 13, 2024
891b66c
LINT: Fix rubocop issue `Style/RedundantAssignment`
Lubosky May 13, 2024
dafc554
LINT: Fix rubocop issue `Style/BarePercentLiterals`
Lubosky May 13, 2024
e8b5958
LINT: Fix rubocop issue `Style/NestedParenthesizedCalls`
Lubosky May 13, 2024
5c7a9b6
LINT: Fix rubocop issue `Style/IfInsideElse`
Lubosky May 13, 2024
3c15063
LINT: Fix rubocop issue `Rails/Blank`
Lubosky May 13, 2024
a18fde5
LINT: Fix rubocop issue `Style/RedundantPercentQ`
Lubosky May 13, 2024
1fa7bce
LINT: Fix rubocop issue `Layout/SpaceBeforeBlockBraces`
Lubosky May 13, 2024
5386276
LINT: Fix rubocop issue `Layout/MultilineArrayBraceLayout`
Lubosky May 13, 2024
7bacab6
LINT: Fix rubocop issue `Lint/SymbolConversion`
Lubosky May 13, 2024
0eaa23b
LINT: Fix rubocop issue `Layout/SpaceInsideArrayLiteralBrackets`
Lubosky May 13, 2024
6c14631
LINT: Fix rubocop issue `Performance/StringIdentifierArgument`
Lubosky May 14, 2024
8d3acdc
LINT: Fix rubocop issue `Style/PercentLiteralDelimiters`
Lubosky May 14, 2024
6005e69
LINT: Fix rubocop issue `Style/HashSyntax`
Lubosky May 14, 2024
8e9f6b9
LINT: Fix rubocop issue `Style/RedundantReturn`
Lubosky May 14, 2024
5ed2a56
LINT: Fix rubocop issue `Performance/StringReplacement`
Lubosky May 14, 2024
abbd5ec
LINT: Fix rubocop issue `Lint/UselessAssignment`
Lubosky May 14, 2024
144aa0c
LINT: Fix rubocop issue `Rails/TimeZone`
Lubosky May 14, 2024
3f3cfa9
LINT: Fix rubocop issue `Rails/NegateInclude`
Lubosky May 14, 2024
fdfd026
LINT: Fix rubocop issue `Rails/ApplicationRecord`
Lubosky May 14, 2024
b554c52
LINT: Fix rubocop issue `Style/IdenticalConditionalBranches`
Lubosky May 14, 2024
5985c09
LINT: Enforce `comma` instead of `consistent_comma`
Lubosky May 14, 2024
1b65507
LINT: Fix rubocop issue `Lint/AssignmentInCondition`
Lubosky May 14, 2024
286bb5e
LINT: Fix rubocop issue `Lint/DuplicateMethods`
Lubosky May 14, 2024
1d45bd8
LINT: Fix rubocop issue `Performance/RedundantMerge`
Lubosky May 14, 2024
506d51b
LINT: Fix rubocop issue `Style/MapIntoArray`
Lubosky May 14, 2024
7a42455
LINT: Fix rubocop issue `Style/SlicingWithRange`
Lubosky May 14, 2024
c24f590
LINT: Fix rubocop issue `Performance/InefficientHashSearch`
Lubosky May 14, 2024
0213fb7
LINT: Fix rubocop issue `Performance/StringInclude`
Lubosky May 14, 2024
913af88
LINT: Disable rubocop issue `Performance/MapCompact`
Lubosky May 14, 2024
83dbd82
LINT: Fix rubocop issue `Style/StringLiterals`
Lubosky May 14, 2024
b1f7256
LINT: Fix rubocop issue `Style/MixinUsage`
Lubosky May 14, 2024
9381e34
Fix code injection warning by checking value against whitelisted values
Lubosky May 14, 2024
6f7c29f
LINT: Fix rubocop issue `Rails/FilePath`
Lubosky May 14, 2024
fbc889f
LINT: Fix rubocop issue `Rails/OutputSafety`
Lubosky May 14, 2024
ed42346
LINT: Fix rubocop issue `Rails/InverseOf`
Lubosky May 14, 2024
49ab4c7
LINT: Fix rubocop issue `Lint/IneffectiveAccessModifier`
Lubosky May 14, 2024
0cdf8d8
LINT: Fix rubocop issue `Performance/MapMethodChain`
Lubosky May 14, 2024
5426d9c
LINT: Fix rubocop issue `Lint/DuplicateMethods`
Lubosky May 14, 2024
4798b74
LINT: Fix rubocop issue `Performance/CollectionLiteralInLoop`
Lubosky May 14, 2024
ffe0ee4
LINT: Disable RuboCop issue `Rails/LexicallyScopedActionFilter`
Lubosky May 14, 2024
592a7bf
LINT: Move class methods above `private` section
Lubosky May 14, 2024
77d8ede
LINT: Disable RuboCop check `Rails/SkipsModelValidations`
Lubosky May 14, 2024
7ca153d
LINT: Disable RuboCop issue `Rails/HasManyOrHasOneDependent`
Lubosky May 14, 2024
d313b53
LINT: Fix RuboCop issue `Rails/Output`
Lubosky May 14, 2024
fe1dbb8
LINT: Disable RuboCop check `Style/SafeNavigation`
Lubosky May 14, 2024
dcdd611
LINT: Disable RuboCop check `Lint/BooleanSymbol`
Lubosky May 14, 2024
40fa82b
LINT: Fix RuboCop issue `Security/Eval`
Lubosky May 15, 2024
ba8d740
LINT: Disable RuboCop offenses for `Rails/UniqueValidationWithoutIndex`
Lubosky May 15, 2024
b70733a
Whitelist sortable fields/columns
Lubosky May 15, 2024
74fdf6c
LINT: Fix RuboCop issue `Rails/HelperInstanceVariable`
Lubosky May 19, 2024
313e9fb
Merge branch 'main' into rubocop-upgrade
TheDancingClown Jun 11, 2024
273b75c
Merge pull request #2919 from bitzesty/rubocop-upgrade
TheDancingClown Jun 11, 2024
279e9c5
Sets from and to variables for error
TheDancingClown Jun 14, 2024
fc1164c
fix simplecov configuration to report relevant spec coverage
dreamfall May 22, 2024
7a2454e
add specs on form/account controllers
dreamfall May 22, 2024
4561fe5
Merge pull request #2963 from bitzesty/improve-spec-coverage
Lubosky Jun 14, 2024
a62a752
Removes custom error validation
TheDancingClown Jun 14, 2024
512dd99
Merge branch 'main' into a11y-radio
TheDancingClown Jun 14, 2024
3903fb3
Merge pull request #2964 from bitzesty/a11y-radio
TheDancingClown Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
14 changes: 14 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs
# @see http://editorconfig.org
root = true

[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = spaces
tab_width = 2

[*.{rb,rake,erb,slim,js,ts,coffee,json,yml,css,pcss,scss,sh,markdown,md,html}]
indent_size = 2
58 changes: 44 additions & 14 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ Layout/SpaceInsideHashLiteralBraces:
Enabled: true
EnforcedStyle: space

# If we want a boolean called :true, we should allow that. These are likely not mistakes.
Lint/BooleanSymbol:
Enabled: false

Metrics/ModuleLength:
Enabled: false

Expand All @@ -92,6 +96,9 @@ Naming/VariableNumber:
Naming/MemoizedInstanceVariableName:
EnforcedStyleForLeadingUnderscores: optional

Performance/MapCompact:
Enabled: false

Rails:
Enabled: true

Expand All @@ -102,39 +109,62 @@ Rails/ApplicationRecord:
Rails/FindBy:
Enabled: false

Rails/HasManyOrHasOneDependent:
Enabled: false

Rails/Output:
Exclude:
- lib/**/*
- db/migrate/**/*.rb

Rails/SkipsModelValidations:
Exclude:
- db/migrate/**/*.rb
- spec/**/*.rb
Enabled: false

Style/HashConversion:
Rails/UnknownEnv:
Environments:
- production
- staging
- development
- test

Style/ArgumentsForwarding:
Enabled: false

Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: comma
Style/Documentation:
Enabled: false

Style/TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/EmptyMethod:
EnforcedStyle: compact

Style/TrailingCommaInArguments:
EnforcedStyleForMultiline: consistent_comma
Style/HashConversion:
Enabled: false

Style/WordArray:
MinSize: 0
Style/NumericLiteralPrefix:
Enabled: false

Style/SafeNavigation:
Enabled: false

Style/SingleLineMethods:
AllowIfMethodIsEmpty: true

Style/StringLiterals:
EnforcedStyle: double_quotes

Style/StringLiteralsInInterpolation:
EnforcedStyle: double_quotes

Style/Documentation:
Enabled: false
Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: comma

Style/TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: comma

Style/TrailingCommaInArguments:
EnforcedStyleForMultiline: comma

Style/WordArray:
MinSize: 0

Metrics/ClassLength:
Enabled: false
Loading
Loading