Fix: Adds missing labels for admin/form_answer#show

Signed-off-by: Louis Kirkham <[email protected]>
bitzesty · Nov 15, 2024 · 2049015 · 2049015
1 parent 15be1b1
commit 2049015
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/app/views/admin/audit_certificate/_form.html.slim b/app/views/admin/audit_certificate/_form.html.slim
@@ -15,10 +15,11 @@
             span[aria-hidden="true"] &times;
 
     .attachment-link.if-js-hide
+      = form.label :attachment, "Attach document", class: "visuallyhidden", for: "audit_certificate_attachment"
       = form.file_field :attachment
 
     .form-group
-      label.form-label Document title
+      = form.label :attachment, "Document title", class: "form-label", for: "audit_certificate_attachment_input"
       = form.text_field :attachment, class: "form-control attachment-title", id: "audit_certificate_attachment_input"
 
     .form-actions.text-right

diff --git a/app/views/admin/figures_and_vat_returns/_form.html.slim b/app/views/admin/figures_and_vat_returns/_form.html.slim
@@ -15,6 +15,7 @@
             span[aria-hidden="true"] &times;
 
     .attachment-link.if-js-hide
+      = form.label :attachment, "Attach document", class: "visuallyhidden"
       = form.file_field :attachment
 
     .form-actions.text-right

diff --git a/app/views/admin/form_answers/appraisal_form_components/_rag_section.html.slim b/app/views/admin/form_answers/appraisal_form_components/_rag_section.html.slim
@@ -7,9 +7,10 @@
   .form-container
     = f.input section.rate,
               as: :select,
-              label: false,
+              label: section.label,
               collection: form.options,
-              input_html: { class: "if-js-hide", "data-updated-section" => section.rate, id: "#{f.object.position}_#{section.desc}_select" }
+              input_html: { class: "if-js-hide", "data-updated-section" => section.rate, id: "#{f.object.position}_#{section.desc}_select" },
+              label_html: { class: "visuallyhidden" }
 
     label.form-label.form-label-rag for="#{f.object.position}_#{section.desc}_comment"
       span.rag_section_label

diff --git a/app/views/admin/form_answers/appraisal_form_components/_verdict_section.html.slim b/app/views/admin/form_answers/appraisal_form_components/_verdict_section.html.slim
@@ -6,9 +6,10 @@
   .form-container
     = f.input section.rate,
               as: :select,
-              label: false,
+              label: section.label,
               collection: form.options,
-              input_html: { class: "if-js-hide", "data-updated-section"  => section.desc, id: "#{f.object.position}_#{section.desc}_select"}
+              input_html: { class: "if-js-hide", "data-updated-section"  => section.desc, id: "#{f.object.position}_#{section.desc}_select"},
+              label_html: { class: "visuallyhidden" }
 
     label.form-label.form-label-rag for="#{f.object.position}_verdict"
       = section.label