Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the use of javascript modules so that issue #378 no longer occurs.
I'm happy to refactor how we add the anonymous function for creating a javascript module. Right now, I include the open tag in the sjcl.js file, and the close tag in the footer.js file. I can also envision other approaches like using
echo "}(sjcl));" >>
in the makefile to introduce the close tags necessary for making sjcl a javascript module (this would save us the extra footer.js file)I also added an additional test to ensure that issue #378 is solved, and all other defined tests pass.
Fundamentally, though, I'm not sure why the special code compression included with this library exists--I believe there are now ways to package code for npm without custom compression, and this could make for a cleaner module approach than concatenating all
core/
files. Moreover, this would get rid of theu
andt
minimized function names that causing issue #378 in the first place.