Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix accelerometerCollector #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix accelerometerCollector #335

wants to merge 1 commit into from

Conversation

shkoder
Copy link

@shkoder shkoder commented May 17, 2017

fix accelerometerCollector for the case when ev.accelerationIncludingGravity is null (w3c/deviceorientation@ca8af6b)

@shkoder
Copy link
Author

shkoder commented May 17, 2017

tests fail because of google/closure-compiler#2487

@Nilos
Copy link
Collaborator

Nilos commented May 18, 2017

Any ideas on how we could get the tests green again?

@shkoder
Copy link
Author

shkoder commented May 18, 2017

The easiest way to is revert ae73ae7 and b179f12
When the closure compiler issue is resolved, they can be brought back.

@shkoder
Copy link
Author

shkoder commented May 18, 2017

e.g. #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilos Nilos Nilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shkoder @Nilos