Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastly Compute actions #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alex8bitw
Copy link

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/SRE-1718

๐Ÿ“” Objective

Actions for Fastly Compute workflows

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@alex8bitw alex8bitw requested a review from a team as a code owner January 15, 2025 04:38
Copy link

github-actions bot commented Jan 15, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 94a3b022-8d38-4d0c-993d-5140ce4d7c0d

Great job, no security vulnerabilities found in this Pull Request

@alex8bitw alex8bitw requested a review from sneakernuts January 15, 2025 04:45
@alex8bitw alex8bitw added the enhancement New feature or request label Jan 15, 2025
@alex8bitw alex8bitw added version:patch and removed enhancement New feature or request labels Jan 15, 2025
@alex8bitw alex8bitw enabled auto-merge (squash) January 15, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants