Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #35

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-101

🚧 Type of change

Remove dept-devops from all CODEOWNERS

  • 🐛 Bug fix
  • 🚀 New feature development
  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
  • 🤖 Build/deploy pipeline (DevOps)
  • 🎂 Other

📔 Objective

Remove dept-devops from all CODEOWNERS, and add dept-bre to .github/workflows/release.yml as owner.

📋 Code changes

  • .github/CODEOWNERS: Remove dept-devops from all CODEOWNERS, and add

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner June 10, 2024 12:26
@michalchecinski
Copy link
Contributor Author

coltonhurst
coltonhurst previously approved these changes Jun 20, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
michalchecinski and others added 2 commits October 17, 2024 11:38
Co-authored-by: Vince Grassia <[email protected]>
Co-authored-by: Vince Grassia <[email protected]>
@michalchecinski michalchecinski enabled auto-merge (squash) October 17, 2024 09:39
@michalchecinski michalchecinski merged commit a066b6b into main Oct 21, 2024
3 checks passed
@michalchecinski michalchecinski deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 21, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants