-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1413] Resolve Concurrency Issues in C FFI #981
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 58.04% 58.01% -0.03%
==========================================
Files 197 197
Lines 13633 13640 +7
==========================================
Hits 7913 7913
- Misses 5720 5727 +7 ☔ View full report in Codecov by Sentry. |
For posterity: Going to merge to main, received internal approval to merge as this can be more easily tested by QA when the other integration and binding update PR's come through. This will happen soon as we will not publish until these are merged 😊 It has been tested though by @dani-garcia and I. Both the Go concurrency issues and the Python binding are confirmed to be working. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1413
📔 Objective
The Issue
Through the C FFI, we were running into concurrency issues with multiple Tokio runtimes.
A draft PR showing the concurrency issue with instructions can be found here.
The Fix
This PR fixes this issue for
bitwarden-c
andbitwarden-py
, by preserving the runtime. Thanks @dani-garcia for the fix and working together on this one!Extra
This also refactors the
AccessTokenLogin
type as a follow up for testing purposes for Go as initiated by this PR.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes