Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7915] [deps]: Update Rust crate base64 to >=0.21.2, <0.23 #769

Merged
merged 2 commits into from
May 6, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 3, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
base64 dependencies minor >=0.21.2, <0.22 -> >=0.21.2, <0.23

Release Notes

marshallpierce/rust-base64 (base64)

v0.22.1

Compare Source

  • Correct the symbols used for the predefined alphabet::BIN_HEX.

v0.22.0

Compare Source

  • DecodeSliceError::OutputSliceTooSmall is now conservative rather than precise. That is, the error will only occur if the decoded output cannot fit, meaning that Engine::decode_slice can now be used with exactly-sized output slices. As part of this, Engine::internal_decode now returns DecodeSliceError instead of DecodeError, but that is not expected to affect any external callers.
  • DecodeError::InvalidLength now refers specifically to the number of valid symbols being invalid (i.e. len % 4 == 1), rather than just the number of input bytes. This avoids confusing scenarios when based on interpretation you could make a case for either InvalidLength or InvalidByte being appropriate.
  • Decoding is somewhat faster (5-10%)

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

PM-7915

Copy link
Contributor Author

renovate bot commented May 3, 2024

⚠ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bitwarden/Cargo.toml --package [email protected] --precise 0.22.1
    Updating crates.io index
error: failed to select a version for the requirement `base64 = "^0.21.0"`
candidate versions found which didn't match: 0.22.1
location searched: crates.io index
required by package `wiremock v0.6.0`
    ... which satisfies dependency `wiremock = "^0.6.0"` (locked to 0.6.0) of package `bitwarden v0.5.0 (/tmp/renovate/repos/github/bitwarden/sdk/crates/bitwarden)`
perhaps a crate was updated and forgotten to be re-vendored?

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bitwarden-exporters/Cargo.toml --package [email protected] --precise 0.22.1
    Updating crates.io index
error: failed to select a version for the requirement `base64 = "^0.21.0"`
candidate versions found which didn't match: 0.22.1
location searched: crates.io index
required by package `wiremock v0.6.0`
    ... which satisfies dependency `wiremock = "^0.6.0"` (locked to 0.6.0) of package `bitwarden v0.5.0 (/tmp/renovate/repos/github/bitwarden/sdk/crates/bitwarden)`
perhaps a crate was updated and forgotten to be re-vendored?

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path crates/bitwarden-crypto/Cargo.toml --package [email protected] --precise 0.22.1
    Updating crates.io index
error: failed to select a version for the requirement `base64 = "^0.21.0"`
candidate versions found which didn't match: 0.22.1
location searched: crates.io index
required by package `wiremock v0.6.0`
    ... which satisfies dependency `wiremock = "^0.6.0"` (locked to 0.6.0) of package `bitwarden v0.5.0 (/tmp/renovate/repos/github/bitwarden/sdk/crates/bitwarden)`
perhaps a crate was updated and forgotten to be re-vendored?

@bitwarden-bot bitwarden-bot changed the title [deps]: Update Rust crate base64 to >=0.21.2, <0.23 [PM-7915] [deps]: Update Rust crate base64 to >=0.21.2, <0.23 May 3, 2024
@bitwarden-bot
Copy link

Internal tracking:

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.75%. Comparing base (42e68d3) to head (0637552).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   58.72%   58.75%   +0.02%     
==========================================
  Files         177      177              
  Lines       11501    11501              
==========================================
+ Hits         6754     6757       +3     
+ Misses       4747     4744       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

renovate bot commented May 3, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Contributor

github-actions bot commented May 3, 2024

Logo
Checkmarx One – Scan Summary & Details56aa0112-87c7-4e9f-9f6b-5f3ed7b02e39

No New Or Fixed Issues Found

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hinton For some reason this update gave some errors to renovate and failed to update the lockfile, have you seen this before? I updated the lockfile with cargo update myself and it seems to work fine.

@dani-garcia dani-garcia requested a review from Hinton May 3, 2024 18:36
@dani-garcia dani-garcia merged commit 6b25960 into main May 6, 2024
78 checks passed
@dani-garcia dani-garcia deleted the renovate/base64-0.x branch May 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants