Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async callbacks test #757

Closed
wants to merge 2 commits into from
Closed

Async callbacks test #757

wants to merge 2 commits into from

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented May 1, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Testing both sync and async callbacks with Uniffi, importantly this has a couple of restrictions:

  • Uniffi needs to be updated to 0.27.x Update uniffi to 0.27.x for async traits support #756
  • The traits that we want to be implemented externally need to be defined in the bitwarden-uniffi crate, this is a limitation of uniffi for the moment. In the tests I've duplicated the trait definition and then created a bridge to add compatibility with the original trait definition.

Copy link
Contributor

github-actions bot commented May 1, 2024

Logo
Checkmarx One – Scan Summary & Detailsb280ce51-7abf-42dc-aa90-935fbf816dfc

No New Or Fixed Issues Found

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 61.49%. Comparing base (9fb1144) to head (f3d6a3b).

Files Patch % Lines
crates/bitwarden-uniffi/src/platform/passkeys.rs 0.00% 32 Missing ⚠️
crates/bitwarden/src/platform/passkeys.rs 0.00% 8 Missing ⚠️
crates/bitwarden/src/platform/client_platform.rs 0.00% 5 Missing ⚠️
crates/bitwarden-uniffi/src/error.rs 0.00% 3 Missing ⚠️
crates/bitwarden-uniffi/src/platform/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           ps/update-uniffi     #757      +/-   ##
====================================================
- Coverage             61.78%   61.49%   -0.29%     
====================================================
  Files                   172      174       +2     
  Lines                 10921    10972      +51     
====================================================
  Hits                   6747     6747              
- Misses                 4174     4225      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from ps/update-uniffi to main May 2, 2024 09:29
@dani-garcia dani-garcia closed this May 3, 2024
@dani-garcia dani-garcia deleted the ps/async-callbacks-test branch May 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant