Add sensitive to password strength and password policy #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 61.78% 61.76% -0.02%
==========================================
Files 172 172
Lines 10921 10931 +10
==========================================
+ Hits 6747 6751 +4
- Misses 4174 4180 +6 ☔ View full report in Codecov by Sentry. |
Hinton
approved these changes
May 2, 2024
| @@ -13,7 +14,7 @@ pub(crate) fn password_strength( | |||
| let mut arr: Vec<_> = inputs.iter().map(String::as_str).collect(); | |||
| arr.extend(GLOBAL_INPUTS); | |||
|
|
|||
| zxcvbn(&password, &arr).map_or(0, |e| e.score()) | |||
| zxcvbn(password.expose(), &arr).map_or(0, |e| e.score()) | |||
There was a problem hiding this comment.
I guess zxcvbn will create copies on their end?
There was a problem hiding this comment.
They make at least one yeah, this is inside the zxcvbn function:
let password = password.chars().take(100).collect::<String>();
I'll look later into seeing how that can be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add sensitive to password strength and password policy. This required adding some ways to get the length of a Sensitive String and check if all the characters match a predicate.
The is_empty added to SensitiveString is because there's a lint for
lenimplementation without a correspondingis_empty.