-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1214] Add secrets syncing support to Go #742
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
==========================================
- Coverage 58.77% 58.55% -0.22%
==========================================
Files 177 178 +1
Lines 11501 11544 +43
==========================================
Hits 6760 6760
- Misses 4741 4784 +43 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
Type of change
Objective
Expose secret syncing to the Go language wrapper.
Code changes
crates/bitwarden-json/src/client.rs:
crates/bitwarden-json/src/command.rs:
crates/sdk-schemas/src/main.rs:
Expose secrets sync in schemas
languages/go/README.md:
languages/go/secrets.go:
Add secrets sync in Go language wrapper.
Before you submit