Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark generate_random_bytes to return sensitive #726

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 22, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Make generate_random_bytes return Sensitive. Also migrate derive_shareable_key to accept a sensitive input.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 22, 2024 15:55
Copy link
Contributor

github-actions bot commented Apr 22, 2024

Logo
Checkmarx One – Scan Summary & Details0a86a6e6-e29d-4c2a-b270-d4ca2742f1bc

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (435cecd) to head (9f85fe5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   60.71%   60.76%   +0.04%     
==========================================
  Files         173      173              
  Lines       10638    10651      +13     
==========================================
+ Hits         6459     6472      +13     
  Misses       4179     4179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit a08143d into main Apr 22, 2024
77 checks passed
@Hinton Hinton deleted the ps/sensitive-random-bytes branch April 22, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants