Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set login_method when registering for tde #711

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 12, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We should set login_method when registering TDE keys

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 12, 2024 14:38
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsba793f8b-405a-4b0e-9210-c4d2ef441655

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 60.78%. Comparing base (b611974) to head (2aa4935).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden-crypto/src/keys/master_key.rs 17.64% 14 Missing ⚠️
crates/bitwarden/src/auth/tde.rs 0.00% 8 Missing ⚠️
crates/bitwarden-uniffi/src/auth/mod.rs 0.00% 6 Missing ⚠️
crates/bitwarden/src/auth/client_auth.rs 0.00% 2 Missing ⚠️
crates/bitwarden/src/auth/login/auth_request.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/auth/register.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   60.83%   60.78%   -0.06%     
==========================================
  Files         173      173              
  Lines       10598    10607       +9     
==========================================
  Hits         6447     6447              
- Misses       4151     4160       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from dani-garcia April 15, 2024 09:29
@Hinton Hinton merged commit 6d45212 into main Apr 15, 2024
76 checks passed
@Hinton Hinton deleted the ps/set-login-method-kdf branch April 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants