Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc.md #699

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Remove doc.md #699

merged 2 commits into from
Apr 9, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Apr 9, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove the doc.md now that we have proper documentation in the generated bindings.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia April 9, 2024 11:26
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Logo
Checkmarx One – Scan Summary & Details599441ff-bcb3-4ce0-bdc6-932684eefef6

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (1ccf11b) to head (66b3bef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   60.79%   60.79%           
=======================================
  Files         173      173           
  Lines       10605    10605           
=======================================
  Hits         6447     6447           
  Misses       4158     4158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Apr 9, 2024
@Hinton Hinton merged commit 4a339a9 into main Apr 9, 2024
76 checks passed
@Hinton Hinton deleted the ps/remove-doc branch April 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants