Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1178] Rename Service Accounts to Machine Accounts #698

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

coltonhurst
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Rename instances (& similar) of "service account" to "machine account". This only impacts public facing text, so items in README's, documentation, help docs, etc.

Before you submit

  • Please add unit tests where it makes sense to do so

@coltonhurst coltonhurst self-assigned this Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsd55be020-5406-4323-b919-91405607f0da

No New Or Fixed Issues Found

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.70%. Comparing base (c272758) to head (f25b8e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         173      173           
  Lines       10518    10518           
=======================================
  Hits         6385     6385           
  Misses       4133     4133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title SM-1178: Rename Service Accounts to Machine Accounts [SM-1178] Rename Service Accounts to Machine Accounts Apr 9, 2024
@coltonhurst coltonhurst merged commit 09d2826 into main Apr 10, 2024
77 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1178 branch April 10, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants