Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6764] Move cipher to organization #695

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[PM-6764] Move cipher to organization #695

merged 1 commit into from
Apr 9, 2024

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Added function to allow moving a cipher to an organization, which requires reencrypting the cipher key if it has one.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 79.83871% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 60.80%. Comparing base (d318bbe) to head (b753fc9).

Files Patch % Lines
crates/bitwarden-uniffi/src/vault/ciphers.rs 0.00% 15 Missing ⚠️
...rates/bitwarden/src/mobile/vault/client_ciphers.rs 0.00% 9 Missing ⚠️
crates/bitwarden/src/vault/cipher/cipher.rs 99.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   60.71%   60.80%   +0.08%     
==========================================
  Files         173      173              
  Lines       10513    10600      +87     
==========================================
+ Hits         6383     6445      +62     
- Misses       4130     4155      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Logo
Checkmarx One – Scan Summary & Details48e24545-a67e-4e55-8243-f59974cc6d4e

No New Or Fixed Issues Found

@dani-garcia dani-garcia marked this pull request as ready for review April 4, 2024 14:40
@dani-garcia dani-garcia requested a review from Hinton April 4, 2024 14:40
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a clone operation? So that you can move an org item to yourself.

@dani-garcia
Copy link
Member Author

I figured that on cipher clone the clients would delete the ID and key themselves so that a different pair can be generated, in which case a separate function isn't needed, but we could add a function to keep the symmetry.

@dani-garcia dani-garcia merged commit 1ccf11b into main Apr 9, 2024
76 checks passed
@dani-garcia dani-garcia deleted the ps/cipher-moves branch April 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants