Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark exporters and generators as internal dependencies #660

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 14, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We accidentally exposed exporters and generators without feature flagging them. This PR properly puts them under the internal feature flag.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia March 14, 2024 10:42
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (07a4ceb) to head (e64adba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   60.52%   60.39%   -0.14%     
==========================================
  Files         172      172              
  Lines       10523    10553      +30     
==========================================
+ Hits         6369     6373       +4     
- Misses       4154     4180      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Mar 14, 2024

Logo
Checkmarx One – Scan Summary & Details0f5f77e2-053b-4960-a152-ef21ca1d4f21

No New Or Fixed Issues Found

@Hinton Hinton requested a review from dani-garcia March 14, 2024 11:38
@Hinton Hinton merged commit dd440ba into main Mar 14, 2024
65 checks passed
@Hinton Hinton deleted the ps/export-generator-internal branch March 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants