Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move access token to auth #656

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Move access token to auth #656

merged 2 commits into from
Mar 12, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 12, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Move access token from client to auth.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia March 12, 2024 11:15
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (ec54a89) to head (92237a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   60.53%   60.52%   -0.02%     
==========================================
  Files         172      172              
  Lines       10527    10523       -4     
==========================================
- Hits         6373     6369       -4     
  Misses       4154     4154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Mar 12, 2024

Logo
Checkmarx One – Scan Summary & Details7ad5dcf7-2cf4-4386-8676-62b77edbda9a

No New Or Fixed Issues Found

dani-garcia
dani-garcia previously approved these changes Mar 12, 2024
@Hinton Hinton merged commit 07a4ceb into main Mar 12, 2024
66 checks passed
@Hinton Hinton deleted the ps/move-access-token branch March 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants